Making default value for min_open_files_limit dynamic #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This logic looks good at first glance on my phone. Can you change the name of the function to be aligned with the other default functions? |
ulimit values so trying to increase them above hard limit while running as non-privileged user is not causing error on start-up. See jupyter#5070
shevelevs
force-pushed
the
DynamicDefaultForMinOpenFilesLimit
branch
from
d02a5cf
to
e46a344
Compare
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making default value for min_open_files_limit dependent on user's
ulimit values so trying to increase them above hard limit while
running as non-privileged user is not causing error on start-up.
See #5070