Add env variable support for port options #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to better support use cases relating to containerized environments, this change adds environment variable support for the `--port` option. Since anyone setting a specific port probably doesn't want port retry logic enabled, the `--port-retries` option has also been backed by an env. Option `--port` will be backed by env `JUPYTER_PORT` and still defaults to `8888`. Option `--port-retries` will be backed by env `JUPYTER_PORT_RETRIES` and still defaults to `50`. The CLI options will override those set via the envrionment, but environment values override those set via configuration files. Closes jupyter#5212
blink1073
approved these changes
May 15, 2020
|
Thanks for reviewing this Steve. Updated with master (and again - sorry, the first contained some remnants from the merge). |
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to better support use cases relating to containerized environments,
this change adds environment variable support for the
--portoption. Sinceanyone setting a specific port probably doesn't want port retry logic enabled,
the
--port-retriesoption has also been backed by an env.Option
--portwill be backed by envJUPYTER_PORTand still defaults to8888.Option
--port-retrieswill be backed by envJUPYTER_PORT_RETRIESand stilldefaults to
50.The CLI options will override those set via the environment, but environment
values override those set via configuration files.
Closes #5212