Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env variable support for port options #5221

Merged
merged 3 commits into from
May 16, 2020

Commits on Feb 11, 2020

  1. Add env variable support for port options

    In order to better support use cases relating to containerized environments,
    this change adds environment variable support for the `--port` option.  Since
    anyone setting a specific port probably doesn't want port retry logic enabled,
    the `--port-retries` option has also been backed by an env.
    
    Option `--port` will be backed by env `JUPYTER_PORT` and still defaults to `8888`.
    Option `--port-retries` will be backed by env `JUPYTER_PORT_RETRIES` and still
    defaults to `50`.
    
    The CLI options will override those set via the envrionment, but environment
    values override those set via configuration files.
    
    Closes jupyter#5212
    kevin-bates committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    7a13cd1 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. Configuration menu
    Copy the full SHA
    86ba293 View commit details
    Browse the repository at this point in the history
  2. Fixup after merge

    kevin-bates committed May 15, 2020
    Configuration menu
    Copy the full SHA
    3f39185 View commit details
    Browse the repository at this point in the history