Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: split_cell doesn't always split cell #6017

Merged
merged 3 commits into from Mar 25, 2021

Conversation

gamestrRUS
Copy link
Contributor

This PR resolve issues.
Summary issues: not work split cell at cursor(s) hotkey (Ctrl-Shift--) after this PR
Also add duplicate cell if full cell is selected.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gamestrRUS - this seems to work as you advertise - thank you.

Since I don't feel qualified to comment on the code changes - although they "read" fine to me - I'd like someone from the front-end to check the changes before we merge.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@blink1073 blink1073 added this to the 6.4 milestone Mar 25, 2021
@blink1073 blink1073 merged commit 57d063c into jupyter:master Mar 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl-Shift-- shortcut doesn't always split cell
3 participants