Fix FilesHandler not meet RFC 6713 #6287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: GitHub Action <41898282+github-actions[bot]@users.noreply.github.com>
SHA256 hashes: notebook-6.4.8-py3-none-any.whl: 3e702fcc54b8ae597533c3864793b7a1e971dec9e112f67235828d8a798fd654 notebook-6.4.8.tar.gz: 1e985c9dc6f678bdfffb9dc657306b5469bfa62d73e03f74e8defbf76d284312
|
@Wh1isper could you fix conficts. I will be happy to review after. |
|
Thx a lot for this super quick update. I have just opened #6319 as CI is failing on all 6.4.x PRs. Once CI is fixed, we can further process this change. |
|
Closing as this was fixed in Jupyter Server: jupyter-server/jupyter_server#701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just like https://github.com/tornadoweb/tornado/blob/master/tornado/web.py#L2896
We do some modify here https://github.com/jupyter/notebook/blob/master/notebook/base/handlers.py#L724
but forget FilesHandler
same PR in jupyter server: jupyter-server/jupyter_server#701