Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JupyterLab, audit document viewers #6922

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Update JupyterLab, audit document viewers #6922

merged 1 commit into from
Jun 16, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 15, 2023 •
edited
Loading

Fixes #6783

  • Update to JupyterLab 4.0.2
  • Add imageviewer-extension
  • Check vega-lite
  • Check other document widgets

image

image

image

image

@jtpio jtpio added this to the 7.0 milestone Jun 15, 2023
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/document-widgets

@jtpio jtpio changed the title Update JupyterLab, add image viewer Update JupyterLab, audit document viewers Jun 15, 2023
@jtpio jtpio marked this pull request as ready for review June 15, 2023 08:33
@jtpio jtpio requested a review from andrii-i June 15, 2023 11:23
andrii-i
andrii-i approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening images, CSV files, Vega, all works great now. Thank you @jtpio

@jtpio jtpio merged commit 245c3e9 into jupyter:main Jun 16, 2023
28 of 29 checks passed
@jtpio
Copy link
Member Author

jtpio commented Jun 16, 2023

Thanks @andrii-i for the review.

@jtpio jtpio deleted the document-widgets branch June 16, 2023 07:39
@jtpio jtpio mentioned this pull request Jun 21, 2023
Closed
@jtpio jtpio mentioned this pull request Oct 11, 2023
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrii-i andrii-i andrii-i approved these changes

Assignees

@jtpio jtpio

Labels
enhancement
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

Audit document widgets for feature parity with JupyterLab
2 participants
@jtpio @andrii-i