Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit document widgets for feature parity with JupyterLab #6783

Closed
JasonWeill opened this issue Mar 22, 2023 · 3 comments · Fixed by #6922
Closed

Audit document widgets for feature parity with JupyterLab #6783

JasonWeill opened this issue Mar 22, 2023 · 3 comments · Fixed by #6922
Labels
Milestone

Comments

@JasonWeill
Copy link
Collaborator

Default document widgets are different in JupyterLab and some builtin document widgets are missing. For example, in JupyterLab, if you click on a CSV file, you see a table view. In Notebook, you open it as a text editor and the table view is not available at all. We need to audit all document widgets in Notebook and test each to make sure they work and that they have the same default as Lab.

This bug was found by @ellisonbg during a bug bash.

@JasonWeill JasonWeill added the bug label Mar 22, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Mar 22, 2023
@jtpio
Copy link
Member

jtpio commented Mar 22, 2023

if you click on a CSV file, you see a table view. In Notebook, you open it as a text editor and the table view is not available at all

Normally they should. For example with JSON files:

image

If I recall correctly CSV files used to be displayed with the table view by default in the Notebook 7 pre-releases. It might be a regression in the latest pre-releases if they don't anymore (maybe due to a JupyterLab update).

Could be worth to add them to the UI tests: #6322

@ellisonbg
Copy link
Contributor

@JasonWeill did we open a separate issue for the bugs related to the image filetype? As I recall, if you open an image from the file browser in notebook 7 it is broken. Should also check vega/vega-lite, json, and other document types that ship with JupyterLab bey default.

@andrii-i
Copy link
Contributor

Mentioned CSS problem should have been fixed by #6799

@andrii-i andrii-i modified the milestones: 7.0, 7.0.x Jun 13, 2023
@andrii-i andrii-i modified the milestones: 7.0.x, 7.0 Jun 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants