Added a keyboard shortcut for renaming the current tab. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we provide a way for the kernel to set the tab title as well (#147), how should they interact? Last one wins (as implemented now)? Or should the user manually setting it block changes coming from the kernel? |
|
If we don't do #147 for a while, I think this is OK, but I'll give @ccordoba12 a chance to have a look at it. |
wmvanvliet
suggested changes
Oct 10, 2016
| old_title = self.tab_widget.tabText(self.tab_widget.currentIndex()) | ||
| title, ok = QtGui.QInputDialog.getText(self, | ||
| "Rename Tab", | ||
| "New Title:".format(old_title), |
There was a problem hiding this comment.
we don't need the .format(old_title) here
There was a problem hiding this comment.
I still think the label should read "New title:" and not "New Title", there is no reason to use title casing here.
wmvanvliet
approved these changes
Oct 11, 2016
|
+1 from me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the shortcut Ctrl+R to rename the current tab.
It also appears in the
Windowmenu.Closes #122. Relevant to #100 as well.