Added hotkey to rename the QtConsole window. #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmvanvliet
suggested changes
Oct 11, 2016
| old_title = self.windowTitle() | ||
| title, ok = QtGui.QInputDialog.getText(self, | ||
| "Rename Window", | ||
| "New Title:".format(old_title), |
There was a problem hiding this comment.
unnecessary code. New Title -> New title.
wmvanvliet
approved these changes
Oct 11, 2016
ccordoba12
reviewed
Oct 12, 2016
| self, | ||
| shortcut="Alt+R", | ||
| statusTip="Rename window", | ||
| triggered=self.set_window_title) |
There was a problem hiding this comment.
Please align these lines to the left parenthesis of line 612 to follow pep8
|
+1 from me for this one :-) |
|
Looks like this conflicts with #148, but ok to merge once conflicts are resolved. |
# Conflicts: # qtconsole/mainwindow.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Alt+R hotkey now renames the main QtConsole window.
This closes #100 .