Removed LaTeX handling due to incomplete support #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jupyter#56 Please reject this PR by doing one fixing the functionality instead 😄
asmeurer
added a commit
to asmeurer/qtconsole
that referenced
this pull request
Oct 23, 2015
Currently it just prints an error and gives an empty png. However, there is a lot of LaTeX that matplotlib cannot parse, e.g., matrices. This gives a better user experience for SymPy, which has a text printer that it can fallback to. SymPy cannot just disable the LaTeX printer because it is desired for the notebook, and there is no way for it to enable LaTeX just in the notebook, or change the printer precedence order. I have left in the debug logging of the error (to the terminal). Fixes jupyter#63. This supersedes jupyter#57, although I don't know if it fixes the issue there.
|
Same than #64 slipped through the cracks. I think that even partial support is better than none. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression mentioned in #56
Please reject this PR by doing one fixing the functionality instead 😄