docs: add devenv and linkcheck to Makefile and misc details #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/docs-maintenance
branch
from
b16a8c5
to
87d2dfb
Compare
consideRatio
force-pushed
the
pr/docs-maintenance
branch
from
49c9557
to
8f378d5
Compare
consideRatio
force-pushed
the
pr/docs-maintenance
branch
6 times, most recently
from
7e23b0a
to
a8ca73a
Compare
consideRatio
force-pushed
the
pr/docs-maintenance
branch
2 times, most recently
from
9a65773
to
886d65e
Compare
This was referenced Oct 22, 2022
Merged
consideRatio
added
documentation
and removed
maintenance
consideRatio
changed the title
consideRatio
force-pushed
the
pr/docs-maintenance
branch
from
886d65e
to
c4ed19f
Compare
With documentation in plain markdown and as built myst-markdown we got warnings about the links referencing section headers by name in myst. Like this, we ensure that the built documentation works great instead of compromising on that and getting warnings about it when building the documentation.
consideRatio
force-pushed
the
pr/docs-maintenance
branch
from
c4ed19f
to
b3bdd15
Compare
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Nov 2, 2022
jupyterhub/binderhub#1565 Merge pull request #1565 from consideRatio/pr/docs-maintenance
|
Merging, since it's good to have these. But linkcheck's not run on CI, is it? Should that be a new workflow? Or is there a way to run linkcheck on RTD only on PRs (because real docs builds shouldn't be prevented if a link breaks)? |
|
I think having linkcheck in the ci system for push and prs is too much noise overall, having a weekly/monthly run via schedule and a badge for failing or not in the project readme could make sense i think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related