Skip to content

Conversation

@consideRatio
Copy link
Member

@consideRatio consideRatio commented Nov 3, 2022

I'm refreshing a few projects documentation build system.

In this case, it also meant leaving the old alabaster theme behind and going for sphinx-book-theme. A preview comparison is available.

Related

@consideRatio consideRatio changed the title docs: relocate source files from docs to docs/source docs: switch from alabaster to sphinx-book-theme, and misc docs build system maintenance Nov 4, 2022
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement to me!

@consideRatio
Copy link
Member Author

Thanks @choldgraf! Going for a self-merge with that approval to enable me to rebase #353 on it and resolve a merge conflict that otherwise occur.

@consideRatio consideRatio merged commit 4ee815e into jupyterhub:main Nov 4, 2022
@choldgraf
Copy link
Member

This makes me wonder - does the jupyterhub team have a policy about self merging when there is an approving review? My feeling is that for most PRs, after one approving review we should encourage a merge by anybody unless there are "request changes" present but somebody else, so that you don't need to deal with the decision cost of knowing whether you can self merge

@consideRatio
Copy link
Member Author

Decision cost was a nice concept to relate to!

I agree on that policy I think. Maybe also along with a unburdening clarification for reviewers that that they could do partial reviews ending up in a request for help to understand something or only provide a partial approval that includes a disclaimer that they didn't understand the change details or consequences well enough and ask that another person contribute a review as well.

Pinging a related topic: jupyterhub/team-compass#466

@choldgraf
Copy link
Member

That's what I use the "comment" review feature for. I think it's a helpful way to provide feedback while explicitly signaling that you don't wish to formally approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants