helm-chart: refactor Dockerfile to make it obvious we don't fail to pass built wheels #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
added
maintenance
|
Self merging as this now conflicts with #1648 so I can rebase that on this |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Mar 24, 2023
jupyterhub/binderhub#1638 Merge pull request #1638 from consideRatio/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we actually built the wheel for grpcio correctly in the build-stage, and that was transferred, but I hesitated on that when I saw changes compared to a Dockerfile in z2jh.
With this, I'm making the Dockerfiles align, but in practice the reason for #1636 is that it takes ages to build
grpcioon arm64 where they don't have a wheel published.