maint: refactoring around pycurl as an optional dependency #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/update-pycurl-requirement-handling
branch
from
0b54c28
to
fc3d614
Compare
consideRatio
changed the title
consideRatio
force-pushed
the
pr/update-pycurl-requirement-handling
branch
from
fc3d614
to
7039812
Compare
consideRatio
commented
Mar 24, 2023
consideRatio
force-pushed
the
pr/update-pycurl-requirement-handling
branch
from
7039812
to
00689e0
Compare
consideRatio
force-pushed
the
pr/update-pycurl-requirement-handling
branch
from
00689e0
to
9666eb7
Compare
|
I've done a delayed self-review, and think it makes sense still as it is. I'll go for a self-merge in the intrest of minimizing use of our limited maintenance capacity. |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Apr 19, 2023
jupyterhub/binderhub#1648 Merge pull request #1648 from consideRatio/pr/update-pycurl-requirement-handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw an opportunity to reduce the complexity a bit by relying more on the optional dependency declared in setup.py on
pycurlover specifying it separately. This would be especially relevant if we would enforce a version constraint on pycurl in setup.py.We couldn't reduce the complexity that much since binderhub is installed locally. This is always tricky since requirements.in freezes into requirements.txt using
pip-compilevia theci/refreezescript, and when it does we get an absolute path to install binderhub. And with that, I think we can't avoid issues when we are to install pre-built wheels in the Dockerfile.