Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binderhub image: refreeze requirements.txt #1827

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

jupyterhub-bot
Copy link
Collaborator

The binderhub image's requirements.txt has been refrozen based on requirements.in.

@jupyterhub-bot jupyterhub-bot added the dependencies Pull requests that update a dependency file label Feb 21, 2024
@manics manics closed this Mar 6, 2024
@manics manics reopened this Mar 6, 2024
@@ -130,7 +131,7 @@ pyasn1-modules==0.3.0
# via google-auth
pycparser==2.21
# via cffi
pycurl==7.45.2
pycurl==7.45.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the tests to fail pycurl/pycurl#834

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I've understood the issue, adding --no-binary=pycurl ought to fix it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I failed to get it working in z2jh @minrk, but we have build stages etc and its a bit complicated.

jupyterhub/zero-to-jupyterhub-k8s#3365

I tried to do --no-binary=pycurl etc, but we have multistage builds etc making things a bit complicated, and I didn't got it working.

Practically, I tried adding the --no-binary=pycurl to the pip wheel command in our build stage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that. I believe jupyterhub/zero-to-jupyterhub-k8s#3371 is the missing piece there.

The approach taken here (pip install --no-deps *.whl) already avoids the problem solved by --no-index there, because it doesn't try to recalculate what to install from a requirements file, instead saying "install all these wheel files, don't look anywhere else or think too much about it."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it didn't work! Will investigate further.

@minrk minrk force-pushed the update-image-requirements branch from 69dc5d3 to eefb644 Compare March 21, 2024 08:58
@consideRatio
Copy link
Member

Argh, I messed up - i re-run the watch dependencies script and the commits in this PR were removed.

@minrk do you have them locally to re-push?

image

@minrk minrk force-pushed the update-image-requirements branch from e959af5 to 4957764 Compare March 29, 2024 08:03
@minrk
Copy link
Member

minrk commented Mar 29, 2024

No worries! FWIW, a pushed commit is never really lost on GitHub even if it's not in a current branch. Commits can be fetched by their sha and re-pushed, e.g.

commit=49577647498b24344d86bbec0c8c6e5403ace3dc
git fetch origin $commit # download the commit if you haven't fetched it before
git reset $commit --hard
git push origin update-image-requirements -f

@consideRatio consideRatio merged commit bd0cc80 into main Mar 29, 2024
22 checks passed
@consideRatio consideRatio deleted the update-image-requirements branch March 29, 2024 08:21
@consideRatio
Copy link
Member

Ah, thanks @minrk!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants