unpin pycurl #3371
unpin pycurl #3371
Conversation
make sure to use build-stage wheels by adding --no-index to pip install avoids installing higher-priority wheels from PyPI instead of what we built (i.e. pycurl)
| @@ -21,9 +21,11 @@ FROM python:3.11-bullseye as build-stage | |||
| COPY requirements.txt requirements.txt | |||
| ARG PIP_CACHE_DIR=/tmp/pip-cache | |||
| RUN --mount=type=cache,target=${PIP_CACHE_DIR} \ | |||
| pip install build \ | |||
There was a problem hiding this comment.
I'm not confident why we installed build here, so I'm not confident on seeing it removed - can you motivate the change?
There was a problem hiding this comment.
It was added but never used without comment in #2733.
I believe it was added by mistake, copying what we do in binderhub, which includes building the binderhub wheel itself, which used to be done with python3 -m build --wheel . (not anymore). If you're not building local packages from source via python3 -m build (and not pip wheel, which can also do the same thing), build is never used.
From what I can find, it's here because we used to invoke it here in binderhub, but since https://github.com/jupyterhub/binderhub/pull/1535/files switched to invoking pip wheel, build has not been used in either binderhub or z2jh. It's a tiny unused pure-python package in the build stage, so nobody noticed the very tiny bit of wasted time.
jupyterhub/zero-to-jupyterhub-k8s#3371 Merge pull request #3371 from minrk/unpin-pycurl
and make sure we build it from source with
--no-binary pycurlAlso make sure to use build-stage wheels by adding
--no-indexto pip install.avoids installing higher-priority wheels from PyPI instead of what we built (i.e. pycurl)
--no-indexwas the part missing in #3365, because themanylinux_2_28wheel from PyPI was preferred at install time to thelinux_archwheel that we built.--no-indexensures no contact with PyPI at all at install time.This is a low priority fix to unpin versions going forward, no need to trigger a new patch release.