Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable registry to use oauth 2.0 as well. #797

Merged

Conversation

@shibbas
Copy link
Contributor

commented Feb 23, 2019

Binderhub currently does not seem to support Oauth 2.0 for registry. This change should fix that.

Explanation:
Docker authentication supports Oauth2.0 as per their documentation: https://docs.docker.com/registry/spec/auth/token/#requesting-a-token. However it looks like binderhub has a hard dependency on "token" in the response. See

token = json.loads(auth_resp.body.decode("utf-8", "replace"))["token"]

Azure Container Registry uses Oauth2.0 https://github.com/Azure/acr/blob/master/docs/AAD-OAuth.md, so as it is, binderhub cannot work with ACR.

@shibbas shibbas closed this Feb 23, 2019
@shibbas shibbas reopened this Feb 23, 2019
@shibbas shibbas changed the title enable registry to use oauth 2.0 as well. [WIP] enable registry to use oauth 2.0 as well. Feb 23, 2019
@captainsafia captainsafia changed the title [WIP] enable registry to use oauth 2.0 as well. enable registry to use oauth 2.0 as well. Feb 23, 2019
@captainsafia captainsafia merged commit 64bb3c7 into jupyterhub:master Feb 23, 2019
4 checks passed
4 checks passed
ci/circleci: build_docs Your tests passed on CircleCI!
Details
codecov/patch 60% of diff hit (target 0%)
Details
codecov/project 79.28% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
yuvipanda pushed a commit to jupyterhub/helm-chart that referenced this pull request Feb 23, 2019
@choldgraf choldgraf added the bug label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.