enable registry to use oauth 2.0 as well. #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibbas
changed the title
captainsafia
changed the title
yuvipanda
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binderhub currently does not seem to support Oauth 2.0 for registry. This change should fix that.
Explanation:
Docker authentication supports Oauth2.0 as per their documentation: https://docs.docker.com/registry/spec/auth/token/#requesting-a-token. However it looks like binderhub has a hard dependency on "token" in the response. See
binderhub/binderhub/registry.py
Line 200 in 67d7d68
Azure Container Registry uses Oauth2.0 https://github.com/Azure/acr/blob/master/docs/AAD-OAuth.md, so as it is, binderhub cannot work with ACR.