fix: --custom-header flag implementation #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Jun 2, 2020
consideRatio
force-pushed
the
fix-custom-header-flag
branch
from
d33f890
to
3a21187
Compare
consideRatio
force-pushed
the
fix-custom-header-flag
branch
from
3a21187
to
0bfca2d
Compare
|
@minrk I think this is ready for merge |
|
@minrk as the current implementation isn't working, and I've verified this implementation works with tests. I'll go ahead and self-merge this tomorrow. |
|
I did a another self review of my code and became more confident the implementation to fix the current broken logic makes sense. I'll go ahead and self-merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--custom-headerflag added in #206 didn't seem to work, this PR attempts to fix this and also adds a test to make sure.Given current node-http-server, the key fixes are:
customHeader(s)headersand notcustomHeadersheadersnow needs to get an object, not a list of objectsCloses #223.