Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lookup of host homedir via pwd #302

Merged

Conversation

AdrianoKF
Copy link
Contributor

Fixes issue #299.
The home directory of the user on the host can be looked up via the
pwd database, which is useful when dealing with non-local users
(e.g., through LDAP authentication).

The lookup can be enabled by setting host_homedir_format_string to
an empty string or None.

Fixes issue jupyterhub#299.
The home directory of the user on the host can be looked up via the
`pwd` database, which is useful when dealing with non-local users
(e.g., through LDAP authentication).

The lookup can be enabled by setting `host_homedir_format_string` to
an empty string or `None`.
Copy link
Contributor

@zeehio zeehio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a user in a similar situation, and with the aim of contributing in code review, I just want to say I have reviewed this PR and this code and the feature it brings looks good to me.

@minrk minrk merged commit 67044bf into jupyterhub:master Oct 1, 2019
@minrk
Copy link
Member

minrk commented Oct 1, 2019

Thanks! Sorry for leaving you hanging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants