Whitelist #65
Merged
Whitelist #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitelist is necessary if using GitHub authentication in the wild. This will prevent all users and only enable authorized users.
yuvipanda
reviewed
Sep 1, 2017
images/hub/jupyterhub_config.py
Outdated
| c.Authenticator.admin_users = get_config('admin.users', []) | ||
|
|
||
| if get_config('whitelist.enabled', False): |
There was a problem hiding this comment.
Is this explicit check needed?
|
Thanks for the patch! Two things:
Thank you for the patch! |
Based on feedback: (1) Moved whitelist from a top level config variable to a hub. (2) Removed whitelist.enabled check. (3) Added default value to values.yaml.
|
Thanks for the feedback! I think I got the changes you suggested. Just let me know if more changes needed. |
|
Thanks! |
|
pinging @arokem as we ran into this problem with neurohackweek I believe...just making sure he sees it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitelist is necessary if using GitHub authentication in the wild.
This will prevent all users and only enable authorized users.