Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository license is incorrect #27

Closed
manics opened this issue Jan 27, 2023 · 3 comments · Fixed by #84
Closed

Repository license is incorrect #27

manics opened this issue Jan 27, 2023 · 3 comments · Fixed by #84
Labels
bug Something isn't working

Comments

@manics
Copy link
Member

manics commented Jan 27, 2023

Bug description

This repository is licensed under BSD-3-Clause.

However it bundles and distributes TigerVNC which is GPL-2.0:
https://github.com/jupyterhub/jupyter-remote-desktop-proxy/tree/v1.0/jupyter_remote_desktop_proxy/share/tigervnc

Expected behaviour

Either:

  • Update the license to indicate this bundles third-party binaries under a different license
  • Relicense as GPL-2.0
  • Don't bundle TigerVNC
@manics manics added the bug Something isn't working label Jan 27, 2023
@benz0li
Copy link

benz0li commented Feb 6, 2023

Furthermore, the bundled TigerVNC is x86_64 and will not work on other architectures (e.g. aarch64).

The default version of this extension, i.e. without user installed vncserver, is not suitable for multi-arch docker images.

@manics
Copy link
Member Author

manics commented Sep 27, 2023

In addition to the VNCserver we're also bundling a patched version of noVNC which has an MPL 2 licence:
https://github.com/jupyterhub/jupyter-remote-desktop-proxy/blob/v1.2.1/jupyter_remote_desktop_proxy/share/web/noVNC-1.2.0/LICENSE.txt

This package is distributed on PyPI with a BSD licence
https://github.com/jupyterhub/jupyter-remote-desktop-proxy/blob/v1.2.1/setup.py#L17

After reading https://www.mozilla.org/en-US/MPL/2.0/FAQ/ I'm not sure what we have to do. Is it acceptable that the noVNC license is included in the source code, or do we have to update the PyPI metadata to indicate the package includes files under a different licence?

@yuvipanda
Copy link
Contributor

#77 stops vendoring novnc for this and many other reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants