Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define VNC servers to support #56

Closed
consideRatio opened this issue Aug 25, 2023 · 6 comments
Closed

Define VNC servers to support #56

consideRatio opened this issue Aug 25, 2023 · 6 comments

Comments

@consideRatio
Copy link
Member

This project ships with TigerVNC, but has support for use with TurboVNC as well, and really any vncserver binary:

If a vncserver executable is found in PATH it will be used, otherwise a bundled TightVNC server is run. You can use this to install vncserver with support for other features, for example the Dockerfile in this repository installs TurboVNC for improved OpenGL support.

Should we aim for something simpler to reduce complexity and ensure robustness on what we really can manage to test and maintain? I'm thinking that we could remove TigerVNC for example.

Related

@benz0li
Copy link

benz0li commented Aug 25, 2023

The bundled TigerVNC is x86_64 only.

Debian/Ubuntu has packages for both x86_64 and AArch64

@yuvipanda
Copy link
Contributor

I actually think we should just stop bundling a VNC server completely, and just require it be installed separately. This also solves the licensing issue.

@consideRatio consideRatio changed the title Re-evaluate VNC servers to support? Define VNC servers to support Oct 11, 2023
@consideRatio
Copy link
Member Author

consideRatio commented Oct 11, 2023

I'd like to reach consensus on a path forward among us who have involved in thinking about this so far @cmd-ntrf @benz0li @yuvipanda.

  • Question 1: Do we stop bundling TigerVNC?
  • Question 2: Do we provide install scripts for TigerVNC and/or TurboVNC?
  • Question 3: Do we commit to testing TigerVNC and/or TurboVNC?

Related

Answer template

> **Question 1: Do we stop bundling TigerVNC?**

> **Question 2: Do we provide install scripts for TigerVNC and/or TurboVNC?**

> **Question 3: Do we commit to testing TigerVNC and/or TurboVNC?**

@consideRatio
Copy link
Member Author

consideRatio commented Oct 11, 2023

Question 1: Do we stop bundling TigerVNC?

Yes, its x86_64 specific and it has a licence we are breaking.

Question 2: Do we provide install scripts for TigerVNC and/or TurboVNC?

No, I don't think we should. If we do, we should have it for all the VNC clients we support. My motivation for not suggesting we introduce this is because of the maintenance burden we take on in this project that currently doesn't have tests setup. If we have tests setup, I'm open to re-evaluating this answer.

Question 3: Do we commit to testing TigerVNC and/or TurboVNC?

To me, this is the same as "Do we commit to supporting TigerVNC and/or TurboVNC". I'm open to supporting / testing both and, or just picking TurboVNC - but I'm hesitant to only pick TigerVNC based on what I've understood so far.

@consideRatio consideRatio mentioned this issue Oct 11, 2023
3 tasks
@benz0li
Copy link

benz0li commented Oct 23, 2023

I agree with @consideRatio's answers.

@consideRatio
Copy link
Member Author

We now have tests for turbovnc and tigervnc and its far more clear now, closing as resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants