Remove bundled VNC server #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
requested changes
Feb 5, 2024
|
Amazing work on things @yuvipanda and @manics!!! I've not reviewed the changed lines in the PR but I think this is a good decision! |
|
@manics I've pushed a change with suggested new wording. If this looks good to you, I think we should merge and make a release! |
Closed
consideRatio
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Nice this looks great!
@yuvipanda I opened #87 about making the v2.0.0 release.
consideRatio
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
I pushed 2c210fe as we now no longer copy files to the share folder. It just includes a single bash script that passed pre-commit checks without change.
manics
commented
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27 (incorrect licensing, noarch metadata doesn't match bundled executable in pypi package)