Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TurboVNC broken since commit 447bf86, still in 1.2.1 #54

Closed
benz0li opened this issue Aug 25, 2023 · 13 comments · Fixed by #99
Closed

TurboVNC broken since commit 447bf86, still in 1.2.1 #54

benz0li opened this issue Aug 25, 2023 · 13 comments · Fixed by #99
Labels
bug Something isn't working

Comments

@benz0li
Copy link

benz0li commented Aug 25, 2023

Bug description

Commit 447bf86 breaks the use of TurboVNC.

Expected behaviour

The image should work whether TigerVNC or TurboVNC is used.

Actual behaviour

The image does not work when TurboVNC is used.

How to reproduce

Build image with TurboVNC installed.

  1. Click on 'desktop [↗]'.
  2. See error: Something went wrong, connection is closed.
  3. Check ~/.vnc/<CONTAINER ID>:<DISPLAY NUMBER>.log for details.

Your personal set up

  • OS: macOS 13.5.1 + Docker Desktop 4.22.1

See #47 (comment) for logs and additional information.

@benz0li benz0li added the bug Something isn't working label Aug 25, 2023
@welcome
Copy link

welcome bot commented Aug 25, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@benz0li
Copy link
Author

benz0li commented Aug 25, 2023

FYI @nathanin @domna

@yuvipanda
Copy link
Contributor

@benz0li I don't have comparative experience about turbovnc vs tigervnc. Was there a specific reason you want to use TurboVNC?

@benz0li
Copy link
Author

benz0li commented Aug 25, 2023

@benz0li I don't have comparative experience about turbovnc vs tigervnc. Was there a specific reason you want to use TurboVNC?

https://turbovnc.org/About/TigerVNC. Beyond that, there are no particular reasons.


I forked this project and keep a separate branch for QGIS that works with TurboVNC (in a container): https://github.com/b-data/jupyter-remote-desktop-proxy/tree/QGIS
ℹ️ I use this branch in my JupyterLab QGIS docker stack: https://github.com/b-data/jupyterlab-qgis-docker-stack/blob/cab6f444535284bd6bd26d6fe380bc4c46bb55fe/base/Dockerfile#L372

I can adapt everything to my needs.

@consideRatio
Copy link
Member

This was reported for 1.1.0, we now have 1.2.1 released - is this still an issue?

@benz0li
Copy link
Author

benz0li commented Oct 11, 2023

This was reported for 1.1.0, we now have 1.2.1 released - is this still an issue?

@consideRatio I will check and give feedback within a week.

@benz0li
Copy link
Author

benz0li commented Oct 13, 2023

@consideRatio Just tested: Still the same issue with v1.2.1.

@consideRatio
Copy link
Member

consideRatio commented Oct 13, 2023

Thank you @benz0li for confirming this! Do you have logs available to go with this issue as well?

@consideRatio consideRatio changed the title Commit 447bf86 breaks the use of TurboVNC TurboVNC broken since commit 447bf86, still in 1.2.1 Oct 13, 2023
@benz0li
Copy link
Author

benz0li commented Oct 13, 2023

Thank you @benz0li for confirming this! Do you have logs available to go with this issue as well?

Still the same. See #47 (comment) ff.

@benz0li
Copy link
Author

benz0li commented Oct 13, 2023

I work around this issue using a fork + reverting 447bf86 (#54 (comment)).

And this project uses TigerVNC by default.

So no need to worry.

@benz0li
Copy link
Author

benz0li commented Oct 28, 2023

I have just released a GPU accelerated JupyterLab QGIS image:

cuda-screenshot

TurboVNC + VirtualGL = Fully GPU accelerated OpenGL applications
👉 Requires NVIDIA GPU + NVIDIA Linux driver + NVIDIA Container Toolkit

ℹ️ For more information, see https://github.com/b-data/jupyterlab-qgis-docker-stack/blob/main/CUDA.md

@benz0li
Copy link
Author

benz0li commented Dec 4, 2023

Closed in favour of #56 and #68.

@consideRatio
Copy link
Member

This is still an issue, but fixed in #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants