Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hub/login - breadcrumb with no content #2182

Closed
consideRatio opened this issue Sep 24, 2018 · 4 comments · Fixed by #3103
Closed

hub/login - breadcrumb with no content #2182

consideRatio opened this issue Sep 24, 2018 · 4 comments · Fixed by #3103

Comments

@consideRatio
Copy link
Member

On mobile, while visiting the login page, the breadcrumb can be seen at the top right corner. When clicked, it shows no content.

breadcrumb

@mdivk
Copy link

mdivk commented Oct 3, 2018

maybe at the very bottom of your phone screen? did you swipe your screen up and down, left and right?

@willingc
Copy link
Contributor

willingc commented Oct 4, 2018

@consideRatio Which mobile browser are you using?

@consideRatio
Copy link
Member Author

This was some mobile version of Chrome on an IPhone 8.

Note that there is actually is no content to hide/show with the breadcrumb in this pre-login state, as the desktop view have no buttons etc in the header before the user has logged in. The minor bug is that the breadcrumb is showing no matter what, which gave me the false indication that there was content.

@willingc
Copy link
Contributor

willingc commented Oct 4, 2018

Yes, I was able to reproduce in Safari browser dev tools set to responsive and IPhone8.

I agree with priority and this is a minor bug that shouldn't display the hamburger unless there is content.

kinow added a commit to kinow/jupyterhub that referenced this issue Jun 24, 2020
kinow added a commit to kinow/jupyterhub that referenced this issue Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants