don't set empty values for HOME, SHELL #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So if the user doesn't have a default shell set, this will simply not do the export of |
| env['HOME'] = home | ||
| shell = pwd.getpwnam(self.user.name).pw_shell | ||
| if shell: | ||
| env['SHELL'] = shell |
There was a problem hiding this comment.
Maybe a comment in the code for future readers, indicating that why setting an empty SHELL is problematic.
in weird cases (probably misconfigured systems), these can be empty strings. Leave them unset in such cases.
ellisonbg
added a commit
that referenced
this pull request
Apr 12, 2015
don't set empty values for HOME, SHELL
consideRatio
pushed a commit
to consideRatio/jupyterhub
that referenced
this pull request
Feb 19, 2018
Allow mutliple extraEnv entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in weird cases (probably misconfigured systems), these can be empty strings. Leave them unset in such cases.