Make cookie secure if used over https #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,7 +166,9 @@ def set_hub_cookie(self, user): | |||
| self.set_secure_cookie( | |||
| self.hub.server.cookie_name, | |||
| user.cookie_id, | |||
| path=self.hub.server.base_url) | |||
| path=self.hub.server.base_url, | |||
| secure=(self.request.protocol == 'https') | |||
There was a problem hiding this comment.
What happens if this is set to true when running over unencrypted HTTP?
There was a problem hiding this comment.
It effectively negates setting the cookie at all. The browser will receive the cookie, see that it should only be sent over https, and then refuse to send it back to the server on any future request.
|
apparently setting kwargs = {}
if self.request.protocol == 'https':
kwargs['secure'] = True
self.set_secure_cookie(
...,
**kwargs
) |
minrk
added a commit
that referenced
this pull request
Apr 17, 2015
Make cookie secure if used over https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.