Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin jupyter_telemetry dependency #3067

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Jun 1, 2020

Some changes in jupyter_telemetry are pending that will lead to breaking changes here in jupyterhub. jupyter_telemetry is likely going to require event schemas to explicitly state if+when they are collecting personal data. This is critically important for protecting user's personal data. Once these changes land in jupyter_telemetry, JupyterHub's event schemas will need updating to include the new, required fields.

In the meantime, I think it's wise for jupyterhub to pin its dependency to the current release of jupyter_telemetry so we don't have to coordinate a release of jupyter_telemetry and jupyterhub w/ new event schemas.

I'll update JupyterHub's event schemas once jupyter/telemetry#46 merges and jupyter_telemetry has a new release.

@consideRatio
Copy link
Member

Thanks for considering this Zach! ❤️

@consideRatio consideRatio merged commit fd28e22 into jupyterhub:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants