Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow named_server_limit_per_user type to be callable #4053

Merged
merged 1 commit into from Sep 30, 2022
Merged

Allow named_server_limit_per_user type to be callable #4053

merged 1 commit into from Sep 30, 2022

Conversation

danilopeixoto
Copy link
Contributor

@danilopeixoto danilopeixoto commented Sep 26, 2022 •
edited by minrk

Closes #4038.

@welcome
Copy link

welcome bot commented Sep 26, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@danilopeixoto danilopeixoto changed the title Set named_server_limit_per_user type as integer or callable Set allow_named_servers/named_server_limit_per_user type as integer or callable Sep 26, 2022
@danilopeixoto danilopeixoto changed the title Set allow_named_servers/named_server_limit_per_user type as integer or callable Set named_server_limit_per_user type as integer or callable Sep 26, 2022
@danilopeixoto
Copy link
Contributor Author

Hi @minrk! Added this minimal implementation.

GeorgianaElena
GeorgianaElena reviewed Sep 29, 2022
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @danilopeixoto, thanks for opening the PR 🚀

Can you please also update the docs here with an example and maybe also add a test for named_server_limit_per_user as a callable?

jupyterhub/handlers/base.py Outdated Show resolved Hide resolved
@dietmarw
Copy link
Contributor

This looks good to me @dietmarw, thanks for opening the PR rocket

@GeorgianaElena I guess you mean @danilopeixoto :-)

@GeorgianaElena
Copy link
Member

Yes 😅 Sorry for the cofusion @dietmarw and thanks for pointing this out! I've just updated my comment.

@minrk
Copy link
Member

minrk commented Sep 30, 2022

Thanks @danilopeixoto! And thank you @GeorgianaElena for review!

@minrk minrk merged commit 387e983 into jupyterhub:main Sep 30, 2022
@welcome
Copy link

welcome bot commented Sep 30, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@minrk minrk added the new new features label Nov 24, 2022
@minrk minrk changed the title Set named_server_limit_per_user type as integer or callable Allow named_server_limit_per_user type to be callable Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgianaElena GeorgianaElena GeorgianaElena left review comments

Assignees
No one assigned
Labels
new new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Named server limit per user indeed
4 participants
@danilopeixoto @dietmarw @GeorgianaElena @minrk