Link reference to github oauth config with jupyter #4096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add link to the reference documentation for github oauth configuration with jupyterhub. Fix typos
There was a problem hiding this comment.
Thank you @Christiandike, this is great 🌻 ! I left a small suggestions in-line, which you can accept or modify. But this looks good to go.
GeorgianaElena
added
documentation
outreachy-dec22
Co-authored-by: Georgiana <georgiana.dolocan@gmail.com>
|
Thank you for taking the time to review @GeorgianaElena . I have applied your suggestion |
|
Congrats on your first merged pull request in this project! 🎉 |
|
Thanks @Christiandike 🌻 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add link to the reference documentation for github oauth configuration with jupyterhub. Fix typos