Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium testing: adding new case covered the authorisation page #4298

Merged
merged 4 commits into from Jan 13, 2023

Conversation

mouse1203
Copy link
Contributor

@mouse1203 mouse1203 commented Jan 13, 2023

added new case covered the authorisation page for Selenium testing

added draft version of the test case for the oauth confirmation page
working on test_oauth_page case: added a check of scopes on the service page
updated the locator for "Authorize" button
reused functions from scopes.py
changed the part of comparing scopes on the service page
Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added some suggestions to help simplify and clarify a bit of the logic.

jupyterhub/tests/selenium/test_browser.py Outdated Show resolved Hide resolved
jupyterhub/tests/selenium/test_browser.py Outdated Show resolved Hide resolved
jupyterhub/tests/selenium/test_browser.py Outdated Show resolved Hide resolved
jupyterhub/tests/selenium/test_browser.py Outdated Show resolved Hide resolved
jupyterhub/tests/selenium/test_browser.py Outdated Show resolved Hide resolved
Co-authored-by: Min RK <benjaminrk@gmail.com>
@minrk
Copy link
Member

minrk commented Jan 13, 2023

These tests exercise in more detail that the oauth form actually issues a token with the desired scopes when the form is submitted, unlike the previous tests that use requests.

@minrk minrk marked this pull request as ready for review January 13, 2023 12:34
@minrk minrk merged commit 663857a into jupyterhub:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants