Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'servers' should be a dict of dicts, not a list of dicts in rest-api.yml #4458

Merged
merged 1 commit into from May 25, 2023

Conversation

tfmark
Copy link
Contributor

@tfmark tfmark commented May 24, 2023

Closes #4036.

It seems that the only way to override the additionalProp1 would be to provide a full example. Based on https://swagger.io/docs/specification/data-models/dictionaries/.

image

@welcome
Copy link

welcome bot commented May 24, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@minrk
Copy link
Member

minrk commented May 25, 2023

Thanks!

@minrk minrk merged commit 02de44e into jupyterhub:main May 25, 2023
4 checks passed
@welcome
Copy link

welcome bot commented May 25, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Servers returned by REST API users endpoint is a dictionary (not list) of dictionaries
2 participants