fail if external oauth service lacks required oauth_redirect_uri #4555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and log service creation with oauth enabled/disabled
consideRatio
reviewed
Sep 6, 2023
consideRatio
reviewed
Sep 6, 2023
yuvipanda
reviewed
Sep 11, 2023
| @@ -2501,6 +2501,11 @@ def service_from_orm( | |||
| if orm_service.oauth_client is not None: | |||
| service.oauth_client_id = orm_service.oauth_client.identifier | |||
| service.oauth_redirect_uri = orm_service.oauth_client.redirect_uri | |||
| oauth_msg = f"with ouath_client_id={orm_service.oauth_client.identifier}" | |||
- avoid empty values - replace single check for redirect_uri with broader _oauth_specified
minrk
force-pushed
the
oauth-validate
branch
from
7a7a11f
to
550dec4
Compare
|
Just tested, works ok! Thanks @minrk! |
|
@meeseeksdev backport to 4.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and log service creation with oauth enabled/disabled
closes #4551