jsx: trade yarn for npm #4598
Merged
jsx: trade yarn for npm #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
commented
Oct 3, 2023
| - `npm run build`: Installs all dependencies and bundles the application | ||
| - `npm run hot`: Bundles the application and runs a mock (serverless) version on port 8000 | ||
| - `npm run lint`: Lints JSX with ESLint | ||
| - `npm run lint --fix`: Lints and fixes errors JSX with ESLint / formats with Prettier |
There was a problem hiding this comment.
I want to trade the lint steps here for pre-commit, but not in this PR.
we're already using npm at the top-level, using both yarn and npm complicates things - stop excluding package-lock.json from the repo
consideRatio
approved these changes
Oct 3, 2023
|
I ran |
|
@yuvipanda thanks! We also have a test for that, having mixed it up a few times in the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're already using npm at one level, it's a bit confusing to use a different package manager in a subdirectory. Yarn doesn't really give us anything that npm doesn't, so be consistent.
For consistency, stop blocking
package-lock.jsonfrom git, now that we are dropping yarn.lock.