use $http_host in nginx proxy header #4671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$host is the hostname, $http_host is `hostname[:port]`, which is what's needed here $host works fine in the example because it uses the default port 80, but if it's on a different port it will differ from the http Host header, resulting in cross-origin check errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$host is the hostname, $http_host is
hostname[:port], which is what's needed here if a port is specified.$host works fine in the example because it uses the default port 80/443 in which case the two variables have the same value. But if it's on a different port, the two will differ, resulting in cross-origin check errors in the singleuser websocket requests because
hostname != hostname:port.