Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve paths in disable_user_config #4713

Merged
merged 1 commit into from Feb 27, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 27, 2024

handles home directory being a symlink, which would not be excluded before.

Workaround is to resolve $HOME to its real path:

export HOME=$(realpath $HOME)

prior to launching single-user servers

closes #3804

handles home directory being a symlink
@minrk minrk added the bug label Feb 27, 2024
@consideRatio consideRatio merged commit 9c3f98d into jupyterhub:main Feb 27, 2024
18 checks passed
@minrk minrk deleted the resolve-exclude-home branch February 27, 2024 14:01
@minrk
Copy link
Member Author

minrk commented Feb 29, 2024

@meeseeksdev please backport to 4.x

Copy link

lumberbot-app bot commented Feb 29, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 9c3f98d4273c7ebc7a4d8bc5e05dc0d97c4e4d3e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #4713: resolve paths in disable_user_config'
  1. Push to a named branch:
git push YOURFORK 4.x:auto-backport-of-pr-4713-on-4.x
  1. Create a PR against branch 4.x, I would have named this PR:

"Backport PR #4713 on branch 4.x (resolve paths in disable_user_config)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to disable user config with Jupyter Server
2 participants