server-side sorting of admin page #4722
Conversation
removes in-page sort, which removes sort by server name, sort by running Running column switches from sort to filter, matching the `?state` query parameter in the API needs some CSS on the column widths to avoid jumps when toggling active servers
avoids imperfect logic detecting `?`
next to name filter, so it's not in the table headings merges Running & Actions columns, since it's really just Actions now (server actions & user actions)
server model needs high-level User object for `progress_url` (it probably shouldn't)
|
I moved the active filter next to the name filter. There's lots more room up there. As a result, I merged the 'Running' and 'Actions' column, since there wasn't anything 'Running' about it as it's not a sort column anymore. 
This lets the table flow and resize a bit nicer, because the button 'cell' actually spans 4 columns, so it doesn't get squished as much on narrow screens: 
|
There was a problem hiding this comment.
Excellent, having "only " before in the label makes the function of the added checkbox very clear, and we can afford to be verbose now that we have space where its now located - nice!
I've attempted to do code review on these parts as well and didn't find something that seemed weird - but I also didn't have time to make sure I understood the details with full confidence. Adding tests remain, and you are on that already so I'll go for an approve!
4px margin matches 8px cell padding (margin is added on both sides) and center when buttons collapse to single column
minrk
force-pushed
the
sort-order-admin-ui
branch
from
229c665
to
f47d0a1
Compare
|
alignment was bugging me, here's the buttons on a narrow screen now: 
Arguably, they should collapse into a hamburger menu, but that's one step too far for the level of refactoring I want to do here. |
|
Thanks @consideRatio! |
removes all in-page sort, which removes sort by admin, server name, sort by running, as those are not available from the API.
This builds on #4720 and #4721 to use the new
sortparameter in the GET /users API and persist it in the new view state.This means sort, etc. are always global, no matter how many users there are (closes #3816)
Running column switches from sort to filter, matching the
?statequery parameter in the API (closes #4482). So while you can't show running servers first, you can show only running servers.needed some CSS on the column widths to avoid jumps when toggling active server filter.
demo:
admin-sort.mov
draft because I haven't updated the tests, but it works