admin: update navigation for react-router v6 #4723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't nest trs in trs
minrk
changed the title
consideRatio
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Amazing progress @minrk! Looks right from what i can tell, and improves a now broken state - let's go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navigation wasn't working (edit user, etc.) because it used
historyproperty, rather than v6's navigate/locationmostly a big find/replace, but also fixed the hierarchy of the group property editor,
which was previously computing a nested transpose table, where the table actually had only one row, but in each cell of the table was a number of rows containing keys, values, etc.
which is now fixed to be a standard one-row-per-row table, and the form input is in the table, so it matches.