Fix counts on list users queries #4794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we had some joins to trigger eager loading, but then `query.count()` returns the count of (user, group) and (user, spawner) pairs, not the count of users but the `joinedload` options added later are the right way to do that, so these joins are unnecessary
| add_user(db, app, name=name) | ||
| print(f"{db.query(orm.User).count()} total users") | ||
| user = add_user(db, app, name=name) | ||
| if i % 2: |
There was a problem hiding this comment.
Inline comment here would be helpful
consideRatio
approved these changes
Apr 19, 2024
|
going to resolve the docker timeout in #4795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had some joins to trigger eager loading,
but then
query.count()returns the count of (user, group) and (user, spawner) pairs, not the count of users but thejoinedloadoptions added later are the right way to do that, so these joins are unnecessarycloses #4789