Merge pull request #103 from foxish/fix-returned-labels

Fix return value of _build_common_labels
jupyterhub · Nov 27, 2017 · 06a2e09 · 06a2e09
2 parents 06f3d6c + c44003f
commit 06a2e09
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/kubespawner/spawner.py b/kubespawner/spawner.py
@@ -709,8 +709,8 @@ def _build_common_labels(self, extra_labels):
         if self.name:
             # FIXME: Make sure this is dns safe?
             labels['hub.jupyter.org/servername'] = self.name
-
-        return labels.update(extra_labels)
+        labels.update(extra_labels)
+        return labels
 
     def _build_pod_labels(self, extra_labels):
         labels = {