Skip to content

Commit

Permalink
Merge pull request #726 from consideRatio/pr/test-bumping-kubernetes-…
Browse files Browse the repository at this point in the history
…asyncio

Require jupyterhub 4+, currently latest kubernetes_asyncio, and stop testing k8s 1.23
  • Loading branch information
yuvipanda committed May 16, 2023
2 parents ff8dcf1 + 23f273b commit 5c6801b
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 9 deletions.
15 changes: 9 additions & 6 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ on:
- "docs/**"
- "**.md"
- ".github/workflows/*"
- "!.github/workflows/test-chart.yaml"
- "!.github/workflows/test.yaml"
push:
paths-ignore:
- "docs/**"
- "**.md"
- ".github/workflows/*"
- "!.github/workflows/test-chart.yaml"
- "!.github/workflows/test.yaml"
branches-ignore:
- "dependabot/**"
- "pre-commit-ci-update-config"
Expand All @@ -39,12 +39,15 @@ jobs:
#
include:
# Tests with oldest supported Python, jupyterhub, k8s, and k8s client
#
# NOTE: If lower bounds are updated, also update our test for the
# lower bounds in pyproject.toml.
#
- python: "3.7"
k3s: v1.23
k3s: v1.24
test_dependencies: >-
jupyterhub==1.3.0
kubernetes_asyncio==23.6.0
traitlets==4.3.2
jupyterhub==4.0.0
kubernetes_asyncio==24.2.3
# Test with modern python and k8s versions
- python: "3.9"
Expand Down
8 changes: 8 additions & 0 deletions docs/source/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@

## [Unreleased]

#### Breaking changes

- JupyterHub 4 is now required by KubeSpawner.
[#726](https://github.com/jupyterhub/kubespawner/pull/726)
- Versions of K8s older than 1.24 are no longer supported, KubeSpawner may still
work but this is not guaranteed.
[#726](https://github.com/jupyterhub/kubespawner/pull/726)

## 5.0

### [5.0.0] - 2023-04-19
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ dependencies = [
# bounds in .github/workflows/test.yaml.
"escapism",
"jinja2",
"jupyterhub>=1.3.0",
"kubernetes_asyncio>=23.6.0",
"jupyterhub>=4.0.0",
"kubernetes_asyncio>=24.2.3",
"python-slugify",
"pyYAML",
"traitlets>=4.3.2",
"traitlets",
"urllib3",
]
dynamic = ["version"]
Expand Down

0 comments on commit 5c6801b

Please sign in to comment.