Merge pull request #635 from minrk/wait-for-start-error

catch errors in reflector.start

kubespawner/reflector.py

@@ -378,9 +378,16 @@ async def start(self):
         and not afterwards!
         """
         if self.watch_task and not self.watch_task.done():
-            raise RuntimeError('Task watching for resources is already running')
+            raise RuntimeError(f"Task watching for {self.kind} is already running")
+        try:
+            await self._list_and_update()
+        except Exception as e:
+            self.log.exception(f"Initial list of {self.kind} failed")
+            if not self.first_load_future.done():
+                # anyone awaiting our first load event should fail
+                self.first_load_future.set_exception(e)
+            raise
 
-        await self._list_and_update()
         self.watch_task = asyncio.create_task(self._watch_and_update())
 
     async def stop(self):

kubespawner/spawner.py

@@ -2393,7 +2393,16 @@ def on_reflector_failure():
                 on_failure=on_reflector_failure,
                 **kwargs,
             )
-            asyncio.ensure_future(self.__class__.reflectors[key].start())
+            f = asyncio.ensure_future(self.__class__.reflectors[key].start())
+
+            async def catch_reflector_start():
+                try:
+                    await f
+                except Exception as e:
+                    self.log.exception(f"Reflector for {kind} failed to start.")
+                    sys.exit(1)
+
+            asyncio.create_task(catch_reflector_start())
 
         if replace and previous_reflector:
             # we replaced the reflector, stop the old one