Merge pull request #694 from yuvipanda/server-name

Escape pod label `hub.jupyter.org/servername` (pod annotation remains unescaped)
jupyterhub · Jan 12, 2023 · 8942af4 · 8942af4
2 parents ecac0b0 + 230fd92
commit 8942af4
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/kubespawner/spawner.py b/kubespawner/spawner.py
@@ -1913,7 +1913,9 @@ def _build_pod_labels(self, extra_labels):
         labels.update(
             {
                 'component': self.component_label,
-                'hub.jupyter.org/servername': self.name,
+                'hub.jupyter.org/servername': escapism.escape(
+                    self.name, safe=self.safe_chars, escape_char='-'
+                ).lower(),
             }
         )
         return labels