Merge pull request #619 from nikhiljha/v6-addr-fmt

properly handle IPv6 IPs

kubespawner/spawner.py

@@ -5,6 +5,7 @@
 implementation that should be used by JupyterHub.
 """
 import asyncio
+import ipaddress
 import os
 import string
 import sys
@@ -1934,6 +1935,8 @@ def _get_pod_url(self, pod):
         else:
             proto = "http"
             hostname = pod["status"]["podIP"]
+            if isinstance(ipaddress.ip_address(hostname), ipaddress.IPv6Address):
+                hostname = f"[{hostname}]"
 
         if self.pod_connect_ip:
             hostname = ".".join(

tests/test_spawner.py

@@ -802,3 +802,15 @@ async def test_delete_pvc(kube_ns, kube_client, hub, config):
         else:
             break
     assert pvc_name not in pvc_names
+
+
+async def test_ipv6_addr():
+    """make sure ipv6 addresses are templated into URL correctly"""
+    # https://github.com/jupyterhub/jupyterhub/pull/3020
+    # https://github.com/jupyterhub/kubespawner/pull/619
+
+    spawner = KubeSpawner(
+        _mock=True,
+    )
+    url = spawner._get_pod_url({"status": {"podIP": "cafe:f00d::"}})
+    assert "[" in url and "]" in url