-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expansion of user names fails for strings containing a JSON-like string #743
Comments
Escaping the However this would fail for variables that are not set by in the
Error in the log:
|
Templating should probably only be appplied to Probably the easiest is overriding get_env like: def get_env(self):
env = self.get_env()
env.update(self._expand_all(self.environment))
return env The only inefficiency would be that the un-templated |
Ignores env variables set by JupyterHub itself, which may contain JSON-like strings. Fixes jupyterhub#743
Suggested fix in #759 |
Bug description
Setting environment variables in the single-user server with a JSON value makes kubespawner fail as the python string formatter will raise a key error.
Expected behaviour
The environment variable gets set in the single user environment
Actual behaviour
Spawn fails with a 500 error
How to reproduce
Error: HTTP 500: Internal Server Error (Unhandled error starting server enol.fernandez)
Your personal set up
JupyterHub deployed via helm
kubespawner version: v6.0.0
Logs
The text was updated successfully, but these errors were encountered: