Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with kubernetes 9.0 #294

Merged
merged 4 commits into from Feb 27, 2019
Merged

compatibility with kubernetes 9.0 #294

merged 4 commits into from Feb 27, 2019

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 6, 2019

signature change in kubernetes 9.0

only affects tests, so this doesn't need to prompt a new release

closes #288
reverts #292

signature change in kubernetes 9.0

only affects tests, so this doesn't need to prompt a new release
packages should never strictly pin dependencies,
that is the responsibility of deployments
@minrk minrk changed the title specify body keyword arg compatibility with kubernetes 9.0 Feb 6, 2019
@minrk
Copy link
Member Author

minrk commented Feb 6, 2019

I added a note to travis.yml about why we test with prereleases of dependencies, which seemed to cause some confusion that prompted #292. The failing test was exactly what was supposed to happen so that we could catch and fix the issue before it made it into a real release.

Copy link
Collaborator

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minrk minrk merged commit 7962978 into jupyterhub:master Feb 27, 2019
@minrk minrk deleted the kube-9 branch February 27, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI tests are failing
2 participants