refactor: add pre-commit hook pyupgrade, and run it #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this hook is great. We have not run into troubles by using it in the JupyterHub org so far.
For example, all the changes by
pyupgrade
have always been logically equivalent it seems. If they hadn't been that, it would been a big problem as then it wasn't just formatting etc but actual changes to the code that mattered.The changes in this PR are:
"r"
as an argument toopen
explicitly%s
formatted strings or.format()
formatted strings.class MockObject(object):
becameclass MockObject:
Related