[KubeIngressProxy] Add common_labels option and expand username etc #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
ingress_common_labels
branch
2 times, most recently
from
efe8c42
to
8bfd1e0
Compare
dolfinus
changed the title
dolfinus
force-pushed
the
ingress_common_labels
branch
3 times, most recently
from
d0c8d33
to
7c7c1bd
Compare
consideRatio
added
KubeIngressProxy
dolfinus
force-pushed
the
ingress_common_labels
branch
from
7c7c1bd
to
0eb9a66
Compare
consideRatio
changed the title
consideRatio
approved these changes
Oct 22, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to add custom labels to all objects created by KubeIngressProxy, like Endpoints, Service and Ingress. For example, admin can add here helm release name.
First step of dividing #648 into smaller pieces