ci: Make sure we run the publish workflow on every tag pushed #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
reviewed
Nov 3, 2022
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
consideRatio
approved these changes
Nov 3, 2022
consideRatio
changed the title
|
Woops that was me who broke the release job recently in 9584c13. Sorry! I think what to do now is to not make any new commits etc, but delete the tag, and then re-push it. |
|
Or no... If we do that it won't trigger, as that commit doesn't have this fix... @GeorgianaElena I created another changelog PR. Want to give it another go after merging it? Sorry for the trouble! |
|
@consideRatio I triggered the workflow manually for that commit and it went ok. The release happened and the new version should be on pypi. So don't worry, all should be ok. Sorry for not updating you about it sooner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the publish workflow might fail to run for the tagged commits :/
see #663 (comment)