Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: pyproject.toml, hatchling, tbump, .readthedocs.yaml updates #666

Merged
merged 2 commits into from Nov 9, 2022

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Nov 4, 2022

This is just chore maintenance of our infrastructure surrounding the actual logic of kubespawner.

  • I've iterated a bit on the RELEASE.md document, making it more succint etc and using tbump wich is what jupyterhub/jupyterhub use, and is a maintained project configurable via pyproject.toml. Like this, we drop use of bump2version during the release process.
  • I've removed setup.py entirely in favor of using only pyproject.toml together with the hatchling build system. This is a build system that can help us in more tricky situations as well, such as when we bundle javascript to build etc.
  • I've updated .readthedocs.yaml, just bumping misc versions for good measure and removed an outdated comment only relevant when we relied on a readthedocs CI runner with sphinx version 1 pre-installed etc.

- setup.py and setuptools are replaced by pyproject.toml and hatchling
  as a build system.
- bump2version is replaced by tbump
When we specify build.os in this config, we don't start out with
pre-installed sphinx versions etc and can won't have to worry about
issues caused by pre-installed versions of sphinx etc.
@consideRatio
Copy link
Member Author

Got time to give this a review @yuvipanda?

@yuvipanda yuvipanda merged commit 0446b32 into jupyterhub:main Nov 9, 2022
@yuvipanda
Copy link
Collaborator

What's the worst that could happen? :D Thanks for working on this, @consideRatio

@consideRatio
Copy link
Member Author

consideRatio commented Nov 9, 2022

Another iteration :) thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants